Re: [PATCH] builtin-commit.c: Not add duplicate S-o-b when commit

2012/7/27 Junio C Hamano : >> Signed-off-by: A >> Signed-off-by: B >> Reported-by: C >> >> So I guess duplicate S-o-b is not intentional. > > I think the two commands are doing randomly different things on > garbage input. The order in the input (i.e. your "original") does > not make s

Re: [PATCH] builtin-commit.c: Not add duplicate S-o-b when commit

Jiang Xin writes: > 2012/7/26 Junio C Hamano : >> After stating the observation like the above, please make it a habit >> to say "which is bad because...", if you think it is a bad behaviour >> and the patch is about fixing it. > > Indead before I start, I examine git-commit and git-am, and find

Re: [PATCH] builtin-commit.c: Not add duplicate S-o-b when commit

2012/7/26 Junio C Hamano : > After stating the observation like the above, please make it a habit > to say "which is bad because...", if you think it is a bad behaviour > and the patch is about fixing it. Indead before I start, I examine git-commit and git-am, and find the behaviours of the two co

Re: [PATCH] builtin-commit.c: Not add duplicate S-o-b when commit

Jiang Xin writes: > Scan the whole rfc2822 footer for duplicate S-o-b, not just the last > line of the commit message. > > A commit may have multiple S-o-bs, or other tags, such as: > > some commit log... > > Signed-off-by: C O Mitter > Reported-by: R E Porter > > Because the S-o-b