Re: [PATCH] clear_child_for_cleanup must correctly manage children_to_clean

2012-09-11 Thread Junio C Hamano
Jeff King writes: > Thanks for the patch. Overall it looks good, but let me nit-pick your > commit message a little (not because it is that horrible, but because > you are so close to perfect that I want to fix the minor things and then > encourage you to submit more patches :) ). > ... > > Acked

Re: [PATCH] clear_child_for_cleanup must correctly manage children_to_clean

2012-09-11 Thread Erik Faye-Lund
On Tue, Sep 11, 2012 at 4:32 PM, David Gould wrote: > Iterate through children_to_clean using 'next' fields but with an > extra level of indirection. This allows us to update the chain when > we remove a child and saves us managing several variables around > the loop mechanism. > --- > run-comman

Re: [PATCH] clear_child_for_cleanup must correctly manage children_to_clean

2012-09-11 Thread Jeff King
On Tue, Sep 11, 2012 at 03:32:47PM +0100, David Gould wrote: > Subject: Re: [PATCH] clear_child_for_cleanup must correctly manage > children_to_clean Thanks for the patch. Overall it looks good, but let me nit-pick your commit message a little (not because it is that horrible, but becau