Re: [PATCH] clone: do not segfault when specifying a nonexistent branch

2013-10-09 Thread Ralf Thielow
On Sat, Oct 5, 2013 at 1:55 AM, Duy Nguyen pclo...@gmail.com wrote: On Fri, Oct 4, 2013 at 9:20 PM, Stefan Beller stefanbel...@googlemail.com wrote: I think we should emit a warning additionally? Signed-off-by: Stefan Beller stefanbel...@googlemail.com I think it's nice to credit Robert for

Re: [PATCH] clone: do not segfault when specifying a nonexistent branch

2013-10-07 Thread Duy Nguyen
On Sun, Oct 6, 2013 at 4:27 PM, Stefan Beller stefanbel...@googlemail.com wrote: @@ -688,7 +688,7 @@ static void write_refspec_config(const char* src_ref_prefix, if (option_mirror || !option_bare) { if (option_single_branch !option_mirror) { -

Re: [PATCH] clone: do not segfault when specifying a nonexistent branch

2013-10-06 Thread Stefan Beller
On 10/05/2013 01:55 AM, Duy Nguyen wrote: On Fri, Oct 4, 2013 at 9:20 PM, Stefan Beller stefanbel...@googlemail.com wrote: I think we should emit a warning additionally? Signed-off-by: Stefan Beller stefanbel...@googlemail.com I think it's nice to credit Robert for reporting the fault in

Re: [PATCH] clone: do not segfault when specifying a nonexistent branch

2013-10-04 Thread Duy Nguyen
On Fri, Oct 4, 2013 at 9:20 PM, Stefan Beller stefanbel...@googlemail.com wrote: I think we should emit a warning additionally? Signed-off-by: Stefan Beller stefanbel...@googlemail.com I think it's nice to credit Robert for reporting the fault in the commit message (something like reported-by: