Re: [PATCH] completion: correct zsh detection when run from git-completion.zsh (Re: [PATCH v2] completion: reduce overhead of clearing cached --options)

2018-06-12 Thread Rick van Hattem
On 11 June 2018 at 20:20, Jonathan Nieder wrote: > SZEDER Gábor wrote: > >> Being in RC phase, I'm all for aiming for a minimal solution. >> However, I don't think that the better fix would be erm.. any "less >> minimal": > > Thanks again. May we have your sign-off? > >

Re: [PATCH] completion: correct zsh detection when run from git-completion.zsh (Re: [PATCH v2] completion: reduce overhead of clearing cached --options)

2018-06-12 Thread SZEDER Gábor
On Mon, Jun 11, 2018 at 8:20 PM, Jonathan Nieder wrote: > From: SZEDER Gábor > Subject: completion: correct zsh detection when run from git-completion.zsh > > v2.18.0-rc0~90^2 (completion: reduce overhead of clearing cached > --options, 2018-04-18) worked around a bug in bash's "set" builtin on

Re: [PATCH] completion: correct zsh detection when run from git-completion.zsh (Re: [PATCH v2] completion: reduce overhead of clearing cached --options)

2018-06-12 Thread SZEDER Gábor
On Mon, Jun 11, 2018 at 8:20 PM, Jonathan Nieder wrote: > From: SZEDER Gábor > Subject: completion: correct zsh detection when run from git-completion.zsh > > v2.18.0-rc0~90^2 (completion: reduce overhead of clearing cached > --options, 2018-04-18) worked around a bug in bash's "set" builtin on