Re: [PATCH] config: arbitrary number of matches for --unset and --replace-all

On Thu, Nov 14, 2013 at 08:50:43AM +0100, Thomas Rast wrote: git-config used a static match array to hold the matches we want to unset/replace when using --unset or --replace-all. Use a variable-sized array instead. This in particular fixes the symptoms git-svn had when storing large

Re: [PATCH] config: arbitrary number of matches for --unset and --replace-all

Jeff King p...@peff.net writes: This code is weird to follow because of the fall-throughs. I do not think you have introduced any bugs with your patch, but it seems weird to me that we set the offset at the top of the hunk. If we hit the conditional in the bottom half, we do actually

Re: [PATCH] config: arbitrary number of matches for --unset and --replace-all

On Wed, Nov 13, 2013 at 5:19 AM, Thomas Rast t...@thomasrast.ch wrote: diff --git a/t/t1303-wacky-config.sh b/t/t1303-wacky-config.sh index 46103a1..7d55730 100755 --- a/t/t1303-wacky-config.sh +++ b/t/t1303-wacky-config.sh @@ -47,4 +58,57 @@ test_expect_success 'do not crash on special long