Re: [PATCH] contrib/test-hg*.sh: Do not use PYTHON_PATH

2013-04-17 Thread Felipe Contreras
On Wed, Apr 17, 2013 at 1:36 PM, Felipe Contreras wrote: > On Wed, Apr 17, 2013 at 9:10 AM, Torsten Bögershausen wrote: >> The test cases in contrib/remote-helpers use mercurial and python. >> Before the tests are run, we check if python can import >> "mercurial" and "hggit". >> To run this check

Re: [PATCH] contrib/test-hg*.sh: Do not use PYTHON_PATH

2013-04-17 Thread Felipe Contreras
On Wed, Apr 17, 2013 at 9:10 AM, Torsten Bögershausen wrote: > The test cases in contrib/remote-helpers use mercurial and python. > Before the tests are run, we check if python can import > "mercurial" and "hggit". > To run this check, python pointed out by PYTHON_PATH is used. > This may not work

Re: [PATCH] contrib/test-hg*.sh: Do not use PYTHON_PATH

2013-04-17 Thread Junio C Hamano
Torsten Bögershausen writes: > The test cases in contrib/remote-helpers use mercurial and python. > Before the tests are run, we check if python can import > "mercurial" and "hggit". > To run this check, python pointed out by PYTHON_PATH is used. > This may not work when different python binaries

Re: [PATCH] contrib/test-hg*.sh: Do not use PYTHON_PATH

2013-04-17 Thread Jonathan Nieder
Hi, Torsten Bögershausen wrote: > Git respects PYTHON_PATH, hg does not. Probably more relevant is that contrib/remote-helpers/git-remote-hg has a shebang line of "#!/usr/bin/env python" and hence does not respect PYTHON_PATH. > Use python instead of $PYTHON_PATH to check for installed modules.