Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jonathan Nieder
Thomas Gummerer wrote: git diff --no-index ... currently reads the index, during setup, when calling gitmodules_config(). In the usual case this gives us some performance drawbacks, Makes sense. but it's especially annoying if there is a broken index file. Is this

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jens Lehmann
Am 09.12.2013 16:16, schrieb Jonathan Nieder: Thomas Gummerer wrote: git diff --no-index ... currently reads the index, during setup, when calling gitmodules_config(). In the usual case this gives us some performance drawbacks, Makes sense. Hmm, but this will disable the submodule

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jonathan Nieder
Jens Lehmann wrote: Am 09.12.2013 16:16, schrieb Jonathan Nieder: Thomas Gummerer wrote: git diff --no-index ... currently reads the index, during setup, when calling gitmodules_config(). In the usual case this gives us some performance drawbacks, Makes sense. Hmm, but this will disable

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Thomas Gummerer
Jonathan Nieder jrnie...@gmail.com writes: Thomas Gummerer wrote: git diff --no-index ... currently reads the index, during setup, when calling gitmodules_config(). In the usual case this gives us some performance drawbacks, Makes sense. but it's especially

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jonathan Nieder
Thomas Gummerer wrote: For example I would take one version, use test-dump-cache-tree to dump the cache tree to a file, change the format slightly, use test-dump-cache-tree again, and check the difference with git diff --no-index. Makes a lot of

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Junio C Hamano
Thomas Gummerer t.gumme...@gmail.com writes: git diff --no-index ... currently reads the index, during setup, when calling gitmodules_config(). In the usual case this gives us some performance drawbacks, but it's especially annoying if there is a broken index file. Avoid calling the

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Thomas Gummerer
[Sorry for not seeing this before sending out v2.] Junio C Hamano gits...@pobox.com writes: Thomas Gummerer t.gumme...@gmail.com writes: git diff --no-index ... currently reads the index, during setup, when calling gitmodules_config(). In the usual case this gives us some performance