Re: [PATCH] difftool: always honor "command not found" exit code

2016-08-15 Thread John Keeping
On Mon, Aug 15, 2016 at 01:21:22PM -0700, Junio C Hamano wrote: > "Tom Tanner (BLOOMBERG/ LONDON)" writes: > > > From: gits...@pobox.com > > To: j...@keeping.me.uk > > Cc: Tom Tanner (BLOOMBERG/ LONDON), dav...@gmail.com, git@vger.kernel.org > > At: 08/14/16 04:21:18 > >

Re: [PATCH] difftool: always honor "command not found" exit code

2016-08-15 Thread Junio C Hamano
"Tom Tanner (BLOOMBERG/ LONDON)" writes: > From: gits...@pobox.com > To: j...@keeping.me.uk > Cc: Tom Tanner (BLOOMBERG/ LONDON), dav...@gmail.com, git@vger.kernel.org > At: 08/14/16 04:21:18 > > John Keeping writes: > ... >> POSIX specifies 127 as

Re: [PATCH] difftool: always honor "command not found" exit code

2016-08-15 Thread Tom Tanner (BLOOMBERG/ LONDON)
Would it be possible to also treat signals (128 and above) as 'special' values as well (as I've seen some merge tools self destruct like that from time to time) - Original Message - From: gits...@pobox.com To: j...@keeping.me.uk Cc: Tom Tanner (BLOOMBERG/ LONDON), dav...@gmail.com,

Re: [PATCH] difftool: always honor "command not found" exit code

2016-08-14 Thread David Aguilar
On Sat, Aug 13, 2016 at 12:30:28PM +0100, John Keeping wrote: > At the moment difftool's "trust exit code" logic always suppresses the > exit status of the diff utility we invoke. This is useful because we > don't want to exit just because diff returned "1" because the files > differ, but it's

Re: [PATCH] difftool: always honor "command not found" exit code

2016-08-14 Thread Junio C Hamano
John Keeping writes: > At the moment difftool's "trust exit code" logic always suppresses the > exit status of the diff utility we invoke. This is useful because we > don't want to exit just because diff returned "1" because the files > differ, but it's confusing if the