Re: [PATCH] fast-export: Allow pruned-references in mark file

2013-04-06 Thread Felipe Contreras
On Sat, Apr 6, 2013 at 11:04 AM, Antoine Pelisse apeli...@gmail.com wrote: fast-export can fail because of some pruned-reference when importing a mark file. The problem happens in the following scenario: $ git fast-export --export-marks=MARKS master (rewrite master) $ git prune

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-12-01 Thread Antoine Pelisse
Yeah, I think I agree that you would need to make sure that the other side does not use the revision marked with :2, once you retire the object you originally marked with :2 by pruning. Shouldn't the second export show :1 and :3 but not :2? It feels like a bug in the exporter to me that the

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Felipe Contreras
On Mon, Nov 26, 2012 at 5:03 AM, Junio C Hamano gits...@pobox.com wrote: Antoine Pelisse apeli...@gmail.com writes: fast-export can fail because of some pruned-reference when importing a mark file. The problem happens in the following scenario: $ git fast-export --export-marks=MARKS

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Antoine Pelisse
On Mon, Nov 26, 2012 at 12:37 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 26, 2012 at 5:03 AM, Junio C Hamano gits...@pobox.com wrote: Is this a safe and sane thing to do, and if so why? Could you describe that in the log message here? Why would fast-export try to

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Felipe Contreras
On Mon, Nov 26, 2012 at 2:23 PM, Antoine Pelisse apeli...@gmail.com wrote: On Mon, Nov 26, 2012 at 12:37 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 26, 2012 at 5:03 AM, Junio C Hamano gits...@pobox.com wrote: Is this a safe and sane thing to do, and if so why? Could

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Antoine Pelisse
If that's the case, I don't think it should throw a warning even just skip them. Removing the warning seems fine to me. Then, in the actual export if some of these objects are referenced the export would fail anyway (but they won't). Of course it will fail to export anything that requires

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: On Mon, Nov 26, 2012 at 12:37 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 26, 2012 at 5:03 AM, Junio C Hamano gits...@pobox.com wrote: Is this a safe and sane thing to do, and if so why? Could you describe that in the log

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Antoine Pelisse
I am not sure I follow the above, but anyway, I think the patch does is safe because (1) future fast-export will not refer to these pruned objects in its output (we have decided that these pruned objects are not used anywhere in the history so nobody will refer to them) and (2) we still need

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Felipe Contreras
On Mon, Nov 26, 2012 at 9:04 PM, Antoine Pelisse apeli...@gmail.com wrote: I am not sure I follow the above, but anyway, I think the patch does is safe because (1) future fast-export will not refer to these pruned objects in its output (we have decided that these pruned objects are not used

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-26 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: I am not sure I follow the above, but anyway, I think the patch does is safe because (1) future fast-export will not refer to these pruned objects in its output (we have decided that these pruned objects are not used anywhere in the history so nobody

Re: [PATCH] fast-export: Allow pruned-references in mark file

2012-11-25 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: fast-export can fail because of some pruned-reference when importing a mark file. The problem happens in the following scenario: $ git fast-export --export-marks=MARKS master (rewrite master) $ git prune $ git fast-export