Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)

2013-10-30 Thread Jeff King
On Sat, Oct 26, 2013 at 10:35:17AM +0200, Thomas Rast wrote: Jeff King p...@peff.net writes: diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index 752f5cb..2b4b9a9 100755 [...] +test_atom head *objectname '' +test_atom head *objecttype '' [...] +test_atom tag

Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)

2013-10-30 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sat, Oct 26, 2013 at 10:35:17AM +0200, Thomas Rast wrote: ... Can you quote the *? I may have become somewhat paranoid, but still. This is the first use of the *field syntax, and test_atom seems written to correctly quote its arguments, so why risk it? :-)

Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)

2013-10-26 Thread Thomas Rast
Jeff King p...@peff.net writes: diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index 752f5cb..2b4b9a9 100755 [...] +test_atom head *objectname '' +test_atom head *objecttype '' [...] +test_atom tag *objectname '67a36f10722846e891fbada1ba48ed035de75581' +test_atom tag