Re: [PATCH] format-patch: print in-body From only when needed

2013-09-20 Thread Junio C Hamano
Jeff King p...@peff.net writes: Commit a908047 taught format-patch the --from option, which places the author ident into an in-body from header, and uses the committer ident in the rfc822 from header. The documentation claims that it will omit the in-body header when it is the same as the

Re: [PATCH] format-patch: print in-body From only when needed

2013-09-20 Thread Jeff King
On Fri, Sep 20, 2013 at 11:17:45AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: Commit a908047 taught format-patch the --from option, which places the author ident into an in-body from header, and uses the committer ident in the rfc822 from header. The documentation

Re: [PATCH] format-patch: print in-body From only when needed

2013-09-20 Thread Junio C Hamano
Jeff King p...@peff.net writes: So I think it should be possible to fix our internal consumers ... I'm a little wary of external consumers that might get confused by it. Yeah, thanks for a good summary of analysis. I agree that it would be doable, but it is dubious if it is worth it. ---