Re: [PATCH] format-patch: show 0/1 and 1/1 for singleton patch with cover letter

2016-08-23 Thread Junio C Hamano
Junio C Hamano writes: > This obviously changes the behaviour, but I do not think of a reason > why this change is a bad idea. >> diff --git a/builtin/log.c b/builtin/log.c >> index 92dc34dcb0cc..8e6100fb0c5b 100644 >> --- a/builtin/log.c >> +++ b/builtin/log.c >> @@ -1676,7 +1676,7 @@ int cmd

Re: [PATCH] format-patch: show 0/1 and 1/1 for singleton patch with cover letter

2016-08-23 Thread Jacob Keller
On Tue, Aug 23, 2016 at 2:21 PM, Junio C Hamano wrote: > Junio C Hamano writes: >>> total = nr; >>> -if (!keep_subject && auto_number && total > 1) >>> +if (!keep_subject && auto_number && (total > 1 || cover_letter)) >>> numbered = 1; >>> if (numbered) >>>

Re: [PATCH] format-patch: show 0/1 and 1/1 for singleton patch with cover letter

2016-08-23 Thread Jacob Keller
On Tue, Aug 23, 2016 at 9:33 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> Change the default behavior of git-format-patch to generate numbered >> sequence of 0/1 and 1/1 when generating both a cover-letter and a single >> patch. This standardizes the cover lette

Re: [PATCH] format-patch: show 0/1 and 1/1 for singleton patch with cover letter

2016-08-23 Thread Junio C Hamano
Jacob Keller writes: > From: Jacob Keller > > Change the default behavior of git-format-patch to generate numbered > sequence of 0/1 and 1/1 when generating both a cover-letter and a single > patch. This standardizes the cover letter to have 0/N which helps > distinguish the cover letter from th