Re: [PATCH] git-completion.bash: add support for path completion

2012-12-19 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/12/2012 20:42, Junio C Hamano ha scritto: [...] I am not sure how you would handle the last parameter to git mv, though. That is by definition a path that does not exist, i.e. cannot be completed. Right, the code should be changed. No

Re: [PATCH] git-completion.bash: add support for path completion

2012-12-19 Thread Junio C Hamano
Manlio Perillo manlio.peri...@gmail.com writes: git mv COPYING README X Assuming X is a new untracked directory, do you think it is an usability problem if an user try to do: git mv COPYING README TAB and X does not appear in the completion list? It is hard to say. Will it

Re: [PATCH] git-completion.bash: add support for path completion

2012-12-19 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 19/12/2012 23:49, Junio C Hamano ha scritto: Manlio Perillo manlio.peri...@gmail.com writes: git mv COPYING README X Assuming X is a new untracked directory, do you think it is an usability problem if an user try to do: git mv

Re: [PATCH] git-completion.bash: add support for path completion

2012-12-18 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/12/2012 20:42, Junio C Hamano ha scritto: [...] I am not sure how you would handle the last parameter to git mv, though. That is by definition a path that does not exist, i.e. cannot be completed. Right, the code should be changed. No

Re: [PATCH] git-completion.bash: add support for path completion

2012-12-17 Thread Junio C Hamano
Manlio Perillo manlio.peri...@gmail.com writes: As long as all of the above stops completion at directory boundary, I think the above sounds like a sensible thing to do. e.g. when ls-files gives Documentation/Makefile and Documentation/git.txt, git cmd DocTAB first would give git cmd

Re: [PATCH] git-completion.bash: add support for path completion

2012-12-16 Thread Junio C Hamano
Manlio Perillo manlio.peri...@gmail.com writes: The git-completion.bash script did not implemented full support for completion, for git commands that operate on files from the current working directory or the index. For these commands, only options completion was available. Hrm, git mv