Re: [PATCH] git-gui: sort entries in tclIndex

[Olaf Hering]

To which branch was this applied?
Its still broken in git-2.6.0.

Olaf

On Fri, May 01, Pat Thoyts wrote:

> René Scharfe  writes:
> 
> >Looping in Pat (git-gui maintainer).
> >
> >Am 15.04.2015 um 09:22 schrieb Olaf Hering:
> >> Ping?
> >>
> >> On Tue, Feb 10, Olaf Hering wrote:
> >>
> >>> Ping?
> >>>
> >>> On Mon, Jan 26, Olaf Hering wrote:
> >>>
>  ALL_LIBFILES uses wildcard, which provides the result in directory
>  order. This order depends on the underlying filesystem on the
>  buildhost. To get reproducible builds it is required to sort such list
>  before using them.
> 
>  Signed-off-by: Olaf Hering 
>  ---
>    git-gui/Makefile | 2 +-
>    1 file changed, 1 insertion(+), 1 deletion(-)
> 
>  diff --git a/git-gui/Makefile b/git-gui/Makefile
>  index cde8b2e..7564a18 100644
>  --- a/git-gui/Makefile
>  +++ b/git-gui/Makefile
>  @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>    rm -f $@ ; \
>    echo '# Autogenerated by git-gui Makefile' >$@ && \
>    echo >>$@ && \
>  - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst 
>  lib/,,$p)' >>$@ &&) \
>  + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo 
>  '$(subst lib/,,$p)' >>$@ &&) \
>    echo >>$@ ; \
>   fi
> 
> >
> 
> Applied. Thank you.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] git-gui: sort entries in tclIndex

[René Scharfe]

Looping in Pat (git-gui maintainer).

Am 15.04.2015 um 09:22 schrieb Olaf Hering:

Ping?

On Tue, Feb 10, Olaf Hering wrote:


Ping?

On Mon, Jan 26, Olaf Hering wrote:


ALL_LIBFILES uses wildcard, which provides the result in directory
order. This order depends on the underlying filesystem on the
buildhost. To get reproducible builds it is required to sort such list
before using them.

Signed-off-by: Olaf Hering o...@aepfle.de
---
  git-gui/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-gui/Makefile b/git-gui/Makefile
index cde8b2e..7564a18 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
 rm -f $@ ; \
 echo '# Autogenerated by git-gui Makefile' $@  \
 echo $@  \
-$(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' $@ 
) \
+$(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' 
$@ ) \
 echo $@ ; \
fi



--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] git-gui: sort entries in tclIndex

[Olaf Hering]

Ping?

On Tue, Feb 10, Olaf Hering wrote:

 Ping?
 
 On Mon, Jan 26, Olaf Hering wrote:
 
  ALL_LIBFILES uses wildcard, which provides the result in directory
  order. This order depends on the underlying filesystem on the
  buildhost. To get reproducible builds it is required to sort such list
  before using them.
  
  Signed-off-by: Olaf Hering o...@aepfle.de
  ---
   git-gui/Makefile | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/git-gui/Makefile b/git-gui/Makefile
  index cde8b2e..7564a18 100644
  --- a/git-gui/Makefile
  +++ b/git-gui/Makefile
  @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
   rm -f $@ ; \
   echo '# Autogenerated by git-gui Makefile' $@  \
   echo $@  \
  -$(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' 
  $@ ) \
  +$(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst 
  lib/,,$p)' $@ ) \
   echo $@ ; \
  fi
   
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] git-gui: sort entries in tclIndex

[Olaf Hering]

Ping?

On Mon, Jan 26, Olaf Hering wrote:

 ALL_LIBFILES uses wildcard, which provides the result in directory
 order. This order depends on the underlying filesystem on the
 buildhost. To get reproducible builds it is required to sort such list
 before using them.
 
 Signed-off-by: Olaf Hering o...@aepfle.de
 ---
  git-gui/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/git-gui/Makefile b/git-gui/Makefile
 index cde8b2e..7564a18 100644
 --- a/git-gui/Makefile
 +++ b/git-gui/Makefile
 @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
rm -f $@ ; \
echo '# Autogenerated by git-gui Makefile' $@  \
echo $@  \
 -  $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' 
 $@ ) \
 +  $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst 
 lib/,,$p)' $@ ) \
echo $@ ; \
   fi
  
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html