Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

2014-05-07 Thread Junio C Hamano
Tolga Ceylan tolga.cey...@gmail.com writes: When applying binary patches a full index is required. format-patch already handles this, but diff-tree needs '--full-index' argument to always output full index. When git-p4 runs git-apply to test the patch, git-apply rejects the patch due to

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

2014-05-05 Thread Pete Wyckoff
tolga.cey...@gmail.com wrote on Fri, 02 May 2014 22:40 -0700: This is the error message git-apply emits in this case: error: cannot apply binary patch to 'filename' without full index line error: filename: patch does not apply Cheers, Tolga Any feedback is appreciated. Sorry,

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

2014-05-02 Thread tolga ceylan
This is the error message git-apply emits in this case: error: cannot apply binary patch to 'filename' without full index line error: filename: patch does not apply Cheers, Tolga Any feedback is appreciated. Cheers, Tolga -- To unsubscribe from this list: send the line unsubscribe git in

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

2014-04-26 Thread Pete Wyckoff
tolga.cey...@gmail.com wrote on Thu, 24 Apr 2014 21:46 -0700: When applying binary patches a full index is required. format-patch already handles this, but diff-tree needs '--full-index' argument to always output full index. Signed-off-by: Tolga Ceylan tolga.cey...@gmail.com --- git-p4.py

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

2014-04-26 Thread tolga ceylan
Yes, when git-p4 runs git-apply to test the patch, this fails due to abbreviated blob object names. I think git-apply requires full object names for binary patches. On 04/26/2014 05:43 AM, Pete Wyckoff wrote: tolga.cey...@gmail.com wrote on Thu, 24 Apr 2014 21:46 -0700: When applying binary

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

2014-04-26 Thread tolga ceylan
On 04/26/2014 02:12 PM, tolga ceylan wrote: Yes, when git-p4 runs git-apply to test the patch, this fails due to abbreviated blob object names. I think git-apply requires full object names for binary patches. This looks like a straightforward change, but can you give a bit more background on