Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-28 Thread Michael Haggerty
On 01/27/2013 03:50 PM, John Keeping wrote: When this change was originally made (0846b0c - git-remote-testpy: hash bytes explicitly , I didn't realised that the hex encoding we chose is a bytes to bytes encoding so it just fails with an error on Python 3 in the same way as the original code.

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: When this change was originally made (0846b0c - git-remote-testpy: hash bytes explicitly , I didn't realised that the hex encoding we chose is a bytes to bytes encoding so it just fails with an error on Python 3 in the same way as the original code.

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread John Keeping
On Sun, Jan 27, 2013 at 11:49:39AM -0800, Junio C Hamano wrote: John Keeping j...@keeping.me.uk writes: When this change was originally made (0846b0c - git-remote-testpy: hash bytes explicitly , I didn't realised that the hex encoding we chose is a bytes to bytes encoding so it just fails

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: Thanks; will queue and wait for an Ack from Michael. Does the helper function need to be named with leading underscore, though? ... Since this is a script not a library module I don't feel strongly about it in this case. That is exactly why I

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread John Keeping
On Sun, Jan 27, 2013 at 12:11:20PM -0800, Junio C Hamano wrote: John Keeping j...@keeping.me.uk writes: Thanks; will queue and wait for an Ack from Michael. Does the helper function need to be named with leading underscore, though? ... Since this is a script not a library module

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: On Sun, Jan 27, 2013 at 12:11:20PM -0800, Junio C Hamano wrote: John Keeping j...@keeping.me.uk writes: Thanks; will queue and wait for an Ack from Michael. Does the helper function need to be named with leading underscore, though? ...

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: John Keeping j...@keeping.me.uk writes: So I think the answer is habit, but I probably shouldn't have put it in in this case. OK, then I'll queue with a local amend to drop the leading underscore. So this is what I will be queuing (I'd appreciate

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread John Keeping
On Sun, Jan 27, 2013 at 12:47:09PM -0800, Junio C Hamano wrote: I remember that I earlier asked somewhere if we want to say Python 3.x that is older than 3.y is unsupported http://thread.gmane.org/gmane.comp.version-control.git/213920/focus=213926 but I was told that we will support

Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3

2013-01-27 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: On Sun, Jan 27, 2013 at 12:47:09PM -0800, Junio C Hamano wrote: I remember that I earlier asked somewhere if we want to say Python 3.x that is older than 3.y is unsupported