Re: [PATCH] graph.c: visual difference on subsequent series

2015-09-04 Thread Junio C Hamano
Michael J Gruber writes: > How would it? "--left-right" information is requested specifically and > not overridden. Root information is not requested specifically [by the > user]. If this "highlight root prominently" were a config, then using both config and --left-right would mean one of them n

Re: [PATCH] graph.c: visual difference on subsequent series

2015-09-04 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 03.09.2015 19:13: > Michael J Gruber writes: > >>> Is the design of your independent implementation the same except >>> that 'o' is used instead of 'x'? Independent implementation does >>> not make the same design magically better, if that is the case ;-) >> >>

Re: [PATCH] graph.c: visual difference on subsequent series

2015-09-03 Thread Junio C Hamano
Michael J Gruber writes: >> Is the design of your independent implementation the same except >> that 'o' is used instead of 'x'? Independent implementation does >> not make the same design magically better, if that is the case ;-) > > Interestingly, the patch to the tests lists * to o changes on

Re: [PATCH] graph.c: visual difference on subsequent series

2015-09-03 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 27.07.2015 22:17: > Antoine Beaupré writes: > >> Any reason why this patch wasn't included / reviewed? >> ... >>> This patch is similar than the one provided by Milton Soares Filho in >>> 1382734287.31768.1.git.send.email.milton.soares.fi...@gmail.com but was >>

Re: [PATCH] graph.c: visual difference on subsequent series

2015-07-27 Thread Junio C Hamano
Antoine Beaupré writes: > Any reason why this patch wasn't included / reviewed? > ... >> This patch is similar than the one provided by Milton Soares Filho in >> 1382734287.31768.1.git.send.email.milton.soares.fi...@gmail.com but was >> implemented independently and uses the 'o' character instead

Re: [PATCH] graph.c: visual difference on subsequent series

2015-07-27 Thread Antoine Beaupré
Any reason why this patch wasn't included / reviewed? Thanks, A. On 2014-11-10 08:33:32, Antoine Beaupré wrote: > For projects with separate history lines and, thus, multiple root-commits, the > linear arrangement of `git log --graph --oneline` does not allow the user to > spot where the sequenc

Re: [PATCH] graph.c: visual difference on subsequent series

2013-10-28 Thread Junio C Hamano
Milton Soares Filho writes: > On 28 October 2013 13:41, Junio C Hamano wrote: >> I agree to all of the above, including the ugliness of 'x' ;-) >> >> A "blank" may however be hard to spot, if the range is limited, >> though. For example, > > A 'x' looks like termination points in some specifica

Re: [PATCH] graph.c: visual difference on subsequent series

2013-10-28 Thread Milton Soares Filho
On 28 October 2013 13:41, Junio C Hamano wrote: > I agree to all of the above, including the ugliness of 'x' ;-) > > A "blank" may however be hard to spot, if the range is limited, > though. For example, A 'x' looks like termination points in some specification languages such as SDL and MSC and

Re: [PATCH] graph.c: visual difference on subsequent series

2013-10-28 Thread Keshav Kini
Junio C Hamano writes: > [administrivia: please avoid culling addresses from To:/Cc: lines] Yikes, sorry about that. I've been sending messages through Gmane rather than via email, and I didn't realize the list didn't automatically send messages to the appropriate people who are only reading the

Re: [PATCH] graph.c: visual difference on subsequent series

2013-10-28 Thread Junio C Hamano
[administrivia: please avoid culling addresses from To:/Cc: lines] Keshav Kini writes: > What about just putting an extra blank line after every root commit line > (possibly except the last one)? That should make it plenty easy to see > where the root commits are in --oneline mode. I think it

Re: [PATCH] graph.c: visual difference on subsequent series

2013-10-25 Thread Keshav Kini
Milton Soares Filho writes: > On 25 October 2013 15:13, Junio C Hamano wrote: >> Milton Soares Filho writes: >> >>> git log --graph --oneline >>> * a1 >>> * a2 >>> x a3 >>> * b1 >>> * b2 >>> x b3 >> >> I agree that the problem you are trying to solve is a good thing t

Re: [PATCH] graph.c: visual difference on subsequent series

2013-10-25 Thread Milton Soares Filho
On 25 October 2013 15:13, Junio C Hamano wrote: > Milton Soares Filho writes: > >> git log --graph --oneline >> * a1 >> * a2 >> x a3 >> * b1 >> * b2 >> x b3 > > I agree that the problem you are trying to solve is a good thing to > tackle, and I also agree that marking

Re: [PATCH] graph.c: visual difference on subsequent series

2013-10-25 Thread Junio C Hamano
Milton Soares Filho writes: > git log --graph --oneline > * a1 > * a2 > x a3 > * b1 > * b2 > x b3 I agree that the problem you are trying to solve is a good thing to tackle, and I also agree that marking a root commit differently from other commits is one way to solve