Re: [PATCH] http: fix segfault in handle_curl_result

2012-10-12 Thread Junio C Hamano
Jeff King writes: > When we create an http active_request_slot, we can set its > "results" pointer back to local storage. The http code will > fill in the details of how the request went, and we can > access those details even after the slot has been cleaned > up. > ... > However, I'm leaving tha

Re: [PATCH] http: fix segfault in handle_curl_result

2012-10-12 Thread Jeff King
On Fri, Oct 12, 2012 at 02:22:49AM -0400, Jeff King wrote: > We should probably not be passing the slot to handle_curl_results at > all, since it may have already been reused and is not safe to read. The > only thing we do with it is to set up any new auth information in the > curl handle. This d