Re: [PATCH] i18n: make the translation of -u advise in one go

[Jonathan Nieder]

Hi,

Jiang Xin wrote:

> Since status_vprintf() called by status_printf_ln() can handle eol in
> buffer, we could simply join these lines into one paragraph.

Good idea.

[...]
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -1223,16 +1223,12 @@ void wt_status_print(struct wt_status *s)
>   if (s->show_ignored_files)
>   wt_status_print_other(s, &s->ignored, _("Ignored 
> files"), "add -f");
>   if (advice_status_u_option && 2000 < s->untracked_in_ms) {
> - status_printf_ln(s, GIT_COLOR_NORMAL, "");

Tiny nit: I'd suggest keeping the above line, making it:

status_printf_ln(s, GIT_COLOR_NORMAL, "");
status_printf_ln(s, GIT_COLOR_NORMAL,
_("It took ..."
  "... status')."),
s->untracked_in_ms / 1000.0);

That way, the message to be translated doesn't start with a newline,
so translators don't have to worry about preserving it (or removing
it if the layout ever changes in the future, etc).

With that change,
Reviewed-by: Jonathan Nieder 

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i18n: make the translation of -u advise in one go

[Eric Sunshine]

On Thu, Apr 11, 2013 at 10:46 PM, Jiang Xin  wrote:
> i18n: make the translation of -u advise in one go

s/advise/advice/

> The advise (consider use of -u when read_directory takes too long) is

Ditto: s/advise/advice/

> separated into 3 different status_printf_ln() calls, and which brings
> trouble for translators.
>
> Since status_vprintf() called by status_printf_ln() can handle eol in
> buffer, we could simply join these lines into one paragraph.
>
> Signed-off-by: Jiang Xin 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html