Re: [PATCH] name-rev: Allow to omit refs/tags/ part in --refs option when --tags used

2013-06-18 Thread Namhyung Kim
Hi Junio, 2013-06-18 AM 12:27, Junio C Hamano wrote: Namhyung Kim namhyung@lge.com writes: In its current form, when an user wants to filter specific ref using --refs option, she needs to give something like --refs=refs/tags/v1.*. This is not intuitive as users might think it's enough to

Re: [PATCH] name-rev: Allow to omit refs/tags/ part in --refs option when --tags used

2013-06-18 Thread Namhyung Kim
2013-06-18 AM 12:53, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Wouldn't it make more sense to see if the given pattern matches a tail substring of the ref, instead of using the hardcoded strip refs/heads/, refs/tags or refs/, and then match once logic? That way,

Re: [PATCH] name-rev: Allow to omit refs/tags/ part in --refs option when --tags used

2013-06-17 Thread Junio C Hamano
Namhyung Kim namhyung@lge.com writes: In its current form, when an user wants to filter specific ref using --refs option, she needs to give something like --refs=refs/tags/v1.*. This is not intuitive as users might think it's enough to give just actual tag name part like --refs=v1.*. I

Re: [PATCH] name-rev: Allow to omit refs/tags/ part in --refs option when --tags used

2013-06-17 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Wouldn't it make more sense to see if the given pattern matches a tail substring of the ref, instead of using the hardcoded strip refs/heads/, refs/tags or refs/, and then match once logic? That way, --refs=origin/* can find refs/remotes/origin/master