Re: [PATCH] push: document --no-verify

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 02:12:21PM +0200, Thomas Rast wrote:
> "Michael S. Tsirkin"  writes:
> 
> > commit ec9f937727bcb0fa8a3dfe6af68c188e968a added
> > --no-verify flag to git push, but didn't document it.
> > It's a useful flag when using pre-push hooks so
> > add the documentation.
> >
> > Suggested-by: Thomas Rast 
> > Cc: Aaron Schrab 
> > Signed-off-by: Michael S. Tsirkin 
> [...]
> > +-n::
> > +--no-verify::
> > +   This option bypasses the pre-commit and commit-msg hooks.
> > +   See also linkgit:githooks[5].
> > +
> 
> Umm, half of that is not correct :-)
> 
> Push doesn't have the -n short form that git-commit does,

Hmm true - in fact -n means dry-run.

> and the hook
> names are wrong.
> 
> I also ended up writing a patch myself; sorry for not telling you on
> IRC:
> 
>   http://thread.gmane.org/gmane.comp.version-control.git/225141

Great, thanks.

> -- 
> Thomas Rast
> trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] push: document --no-verify

2013-05-22 Thread Thomas Rast
"Michael S. Tsirkin"  writes:

> commit ec9f937727bcb0fa8a3dfe6af68c188e968a added
> --no-verify flag to git push, but didn't document it.
> It's a useful flag when using pre-push hooks so
> add the documentation.
>
> Suggested-by: Thomas Rast 
> Cc: Aaron Schrab 
> Signed-off-by: Michael S. Tsirkin 
[...]
> +-n::
> +--no-verify::
> + This option bypasses the pre-commit and commit-msg hooks.
> + See also linkgit:githooks[5].
> +

Umm, half of that is not correct :-)

Push doesn't have the -n short form that git-commit does, and the hook
names are wrong.

I also ended up writing a patch myself; sorry for not telling you on
IRC:

  http://thread.gmane.org/gmane.comp.version-control.git/225141

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html