Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Ramkumar Ramachandra
jorge-juan.garcia-gar...@ensimag.imag.fr wrote: The format of email list handled is pretty basic for now: $ git send-email --to='Foo f...@example.com, b...@example.com' We thought it would be nice to have a first-step version which works before handling more complex ones such as:

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Mathieu Liénard--Mayor
Le 2013-06-18 12:12, Ramkumar Ramachandra a écrit : jorge-juan.garcia-gar...@ensimag.imag.fr wrote: The format of email list handled is pretty basic for now: $ git send-email --to='Foo f...@example.com, b...@example.com' We thought it would be nice to have a first-step version which

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Ramkumar Ramachandra
Mathieu Liénard--Mayor wrote: Is this a regression? I can't send emails to a recipient whose name contains a comma? It is not. Previously the input would be considered incorrect: Right. It dies with Comma in --to entry: ... This artificial limitation is imposed by 79ee555b (Check and

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread benoît person
+sub split_email_list { +my(@list) = @_; +my @tmp; +my @emails; + for (my $i = 0; $i = $#list; $i++) { + if ($list[$i] =~ /,/) { + @emails = split(/,/, $list[$i]); + } else { + @emails = $list[$i]; + } +

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Ramkumar Ramachandra
jorge-juan.garcia-gar...@ensimag.imag.fr wrote: diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 9f46f22..87641bc 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -1349,4 +1349,39 @@ test_expect_success $PREREQ 'sendemail.aliasfile=~/.mailrc' ' grep

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Mathieu Liénard--Mayor
Le 2013-06-18 12:47, Ramkumar Ramachandra a écrit : jorge-juan.garcia-gar...@ensimag.imag.fr wrote: diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 9f46f22..87641bc 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -1349,4 +1349,39 @@ test_expect_success $PREREQ

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Ramkumar Ramachandra
jorge-juan.garcia-gar...@ensimag.imag.fr wrote: +sub split_email_list { +my(@list) = @_; +my @tmp; +my @emails; + for (my $i = 0; $i = $#list; $i++) { + if ($list[$i] =~ /,/) { + @emails = split(/,/, $list[$i]); + } else { +

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Ramkumar Ramachandra
Mathieu Liénard--Mayor wrote: Shouldn't $ git send-email --cc 'f...@example.com' --cc 'b...@example.com' and $ git send-email --cc 'f...@example.com, b...@example.com' have the exact same effect ? Ah. Perhaps it would be clearer to check the headers directly like in the other tests? --

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Matthieu Moy
Ramkumar Ramachandra artag...@gmail.com writes: Mathieu Liénard--Mayor wrote: Shouldn't $ git send-email --cc 'f...@example.com' --cc 'b...@example.com' and $ git send-email --cc 'f...@example.com, b...@example.com' have the exact same effect ? Ah. Perhaps it would be clearer to

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Junio C Hamano
jorge-juan.garcia-gar...@ensimag.imag.fr writes: From: Jorge Juan Garcia Garcia jorge-juan.garcia-gar...@ensimag.imag.fr Make it so that we can use a list of email in flags instead of having to use one flag per email address. The format of email list handled is pretty basic for now:

Re: [PATCH] send-email: allow use of basic email list in --cc --to and --bcc

2013-06-18 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Doesn't git send-email --to='Foo f...@example.com' --to='b...@example.com' work? If it does, I do not see much point of this change. If you are starting from two pieces of information, why combine it into one, only have the program to split