Re: [PATCH] symbolic-ref: trivial style fix

2013-10-16 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Saying this patch is from me is not really accurate, it's based on a patch by me, or it was reported by me, but it's not really from me. OK, will reword. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body

Re: [PATCH] symbolic-ref: trivial style fix

2013-10-15 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Let's do something like this instead. - We usually refrain from making such a tree-wide change in order to avoid unnecessary conflicts with other real work patches, but

Re: [PATCH] symbolic-ref: trivial style fix

2013-10-15 Thread Jonathan Nieder
Junio C Hamano wrote: From: Felipe Contreras felipe.contre...@gmail.com Subject: C: have space around and || operators [...] builtin/read-tree.c| 2 +- builtin/rev-list.c | 2 +- builtin/symbolic-ref.c | 2 +- compat/regex/regcomp.c | 2 +- xdiff/xemit.c | 2 +- 5 files

Re: [PATCH] symbolic-ref: trivial style fix

2013-10-15 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: - dfa-nodes[node].type == CHARACTER + dfa-nodes[node].type == CHARACTER It took a little staring to see what changed here. The preimage has a tab, probably from an autoformatter gone wild. I don't think fixing it

Re: [PATCH] symbolic-ref: trivial style fix

2013-10-15 Thread Felipe Contreras
Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Let's do something like this instead. - We usually refrain from making such a tree-wide change in order to avoid unnecessary conflicts with