Re: [PATCH] test-lint-duplicates: check numbering in contrib/remote-helpers
On Tue, Apr 2, 2013 at 6:53 PM, Torsten Bögershausen tbo...@web.de wrote: --- contrib/remote-helpers/Makefile| 3 +- contrib/remote-helpers/t5810-test-bzr.sh | 143 +++ contrib/remote-helpers/t5820-test-hg-bidi.sh | 243 +++ contrib/remote-helpers/t5821-test-hg-hg-git.sh | 534 + contrib/remote-helpers/t5830-test-hg.sh| 121 ++ contrib/remote-helpers/test-bzr.sh | 143 --- contrib/remote-helpers/test-hg-bidi.sh | 243 --- contrib/remote-helpers/test-hg-hg-git.sh | 534 - contrib/remote-helpers/test-hg.sh | 121 -- t/Makefile | 2 +- 10 files changed, 1044 insertions(+), 1043 deletions(-) create mode 100755 contrib/remote-helpers/t5810-test-bzr.sh create mode 100755 contrib/remote-helpers/t5820-test-hg-bidi.sh create mode 100755 contrib/remote-helpers/t5821-test-hg-hg-git.sh create mode 100755 contrib/remote-helpers/t5830-test-hg.sh delete mode 100755 contrib/remote-helpers/test-bzr.sh delete mode 100755 contrib/remote-helpers/test-hg-bidi.sh delete mode 100755 contrib/remote-helpers/test-hg-hg-git.sh delete mode 100755 contrib/remote-helpers/test-hg.sh Don't hesitate to format patches with -M :) -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] test-lint-duplicates: check numbering in contrib/remote-helpers
On Tue, Apr 2, 2013 at 12:53 PM, Torsten Bögershausen tbo...@web.de wrote: Running make inside contrib/remote-helpers failes in test-lint-duplicates s/failes/fails/ This was because the regexp to check for duplicate numbers strips everything after the first - in the filename, including the prefix. As a result, 2 pathnames like /contrib/remote-helpers/test-bzr.sh and /contrib/remote-helpers/test-hg-bidi.sh are both converted into /contrib/remote, and reported as duplicate. Improve the regexp: Remove everything after t- (where X stand for a digit) Rename the tests in contrib/remote-helpers into t5810-test-bzr.sh, t5820-test-hg-bidi.sh, t5821-test-hg-hg-git.sh, t5830-test-hg.sh Feed the numbers used in contrib/remote-helpers into t/Makefile and check that numbering is unique across both directories -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
