Re: [PATCH] worktree: accept -f as short for --force for removal

2018-04-17 Thread Eric Sunshine
On Tue, Apr 17, 2018 at 8:17 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> Makes sense. A possible rewrite (of the entire commit message): >> >> worktree: remove: recognize -f as short for --force >> >> Many commands support a --force option, frequently abbreviated as >> -f, ho

Re: [PATCH] worktree: accept -f as short for --force for removal

2018-04-17 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, Apr 17, 2018 at 2:19 PM, Stefan Beller wrote: >> The force flag is very common in many commands and is commonly >> abbreviated with '-f', so add that to worktree removal, too by using >> OPT__FORCE instead of a self cooked OPT_BOOL for force. > > The missing bit o

Re: [PATCH] worktree: accept -f as short for --force for removal

2018-04-17 Thread Eric Sunshine
On Tue, Apr 17, 2018 at 2:19 PM, Stefan Beller wrote: > The force flag is very common in many commands and is commonly > abbreviated with '-f', so add that to worktree removal, too by using > OPT__FORCE instead of a self cooked OPT_BOOL for force. The missing bit of this sentence: ...self co

Re: [PATCH] worktree: accept -f as short for --force for removal

2018-04-16 Thread Eric Sunshine
On Mon, Apr 16, 2018 at 6:16 PM, Stefan Beller wrote: > The force flag is very common in many commands and is commonly > abbreviated with '-f', so add that to worktree removal, too > > Signed-off-by: Stefan Beller > --- > diff --git a/builtin/worktree.c b/builtin/worktree.c > @@ -783,7 +783,7 @@