Re: [PATCH 0/2] Move sequencer

2013-06-08 Thread Felipe Contreras
On Fri, Jun 7, 2013 at 10:35 PM, Ramkumar Ramachandra
 wrote:
> Felipe Contreras wrote:
>>  sequencer.c => builtin/sequencer.c | 160 
>> +---
>>  sequencer.h => builtin/sequencer.h |   4 -
>
> Why exactly?  The plan was to unify continuation semantics, and get
> all the continuation-commands to use the sequencer.  That clearly
> hasn't materialized, but I don't know what this move buys us.

So? The sequencer is only used by builtin commands, and other
continuation commands are also builtins.

The sequencer needs to access methods from builtins/*.o, so unless you
propose that libgit.a includes all the objects in builtins/*.o, this
is the way to go.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] Move sequencer

2013-06-07 Thread Ramkumar Ramachandra
Felipe Contreras wrote:
>  sequencer.c => builtin/sequencer.c | 160 +---
>  sequencer.h => builtin/sequencer.h |   4 -

Why exactly?  The plan was to unify continuation semantics, and get
all the continuation-commands to use the sequencer.  That clearly
hasn't materialized, but I don't know what this move buys us.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html