Re: [PATCH 0/2] recover from failed to apply delta

2013-06-14 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Thu, Jun 13, 2013 at 08:05:21PM -0400, Nicolas Pitre wrote: We already handle the case where we were not able to read the delta from disk. However, when we find that the delta we read does not apply, we simply die. This case is harder to trigger, as

Re: [PATCH 0/2] recover from failed to apply delta

2013-06-14 Thread Jeff King
On Fri, Jun 14, 2013 at 02:51:35PM -0700, Junio C Hamano wrote: Here is a re-roll; the first patch is a small cleanup in t5303 that is required for the new tests to work. Heh, I was doing the same, but I cheated ;-) diff --git a/t/t5303-pack-corruption-resilience.sh

Re: [PATCH 0/2] recover from failed to apply delta

2013-06-14 Thread Junio C Hamano
Jeff King p...@peff.net writes: + # At the beginning of the REF_DELTA representation of $blob_3, + # write 20-byte base object name for $blob_1, instead of $blob_2. + # The binary representation of object name for $blob_1 is found + # at offset 4 + 4 + 256*4 = 1032 for 20