Re: [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions

2013-09-11 Thread Junio C Hamano
Sebastian Schuberth  writes:

> On Wed, Sep 11, 2013 at 6:09 PM, Junio C Hamano  wrote:
>
>> Karsten Blees  writes:
>>
>>> A few minor fixes for the MSVC build.
>>>
>>> Also here: https://github.com/kblees/git/tree/kb/fix-msvc-stat-definitions
>>>
>>> Karsten Blees (3):
>>>   MSVC: fix compile errors due to missing libintl.h
>>>   MSVC: fix compile errors due to macro redefinitions
>>>   MSVC: fix stat definition hell
>>>
>>>  compat/mingw.h   | 21 +
>>>  compat/msvc.h| 15 ---
>>>  config.mak.uname |  1 +
>>>  3 files changed, 18 insertions(+), 19 deletions(-)
>>
>> I won't be a good person to review, suggest improvements on, and/or
>> judge these patches.  I'm Cc'ing regulars who work on mingw port for
>> their help and Ack.
>
> Acked-by: Sebastian Schuberth 

Thanks; will queue these three and your follow-up on top.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions

2013-09-11 Thread Sebastian Schuberth
On Wed, Sep 11, 2013 at 6:09 PM, Junio C Hamano  wrote:

> Karsten Blees  writes:
>
>> A few minor fixes for the MSVC build.
>>
>> Also here: https://github.com/kblees/git/tree/kb/fix-msvc-stat-definitions
>>
>> Karsten Blees (3):
>>   MSVC: fix compile errors due to missing libintl.h
>>   MSVC: fix compile errors due to macro redefinitions
>>   MSVC: fix stat definition hell
>>
>>  compat/mingw.h   | 21 +
>>  compat/msvc.h| 15 ---
>>  config.mak.uname |  1 +
>>  3 files changed, 18 insertions(+), 19 deletions(-)
>
> I won't be a good person to review, suggest improvements on, and/or
> judge these patches.  I'm Cc'ing regulars who work on mingw port for
> their help and Ack.

Acked-by: Sebastian Schuberth 

-- 
Sebastian Schuberth
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions

2013-09-11 Thread Junio C Hamano
Karsten Blees  writes:

> A few minor fixes for the MSVC build.
>
> Also here: https://github.com/kblees/git/tree/kb/fix-msvc-stat-definitions
>
> Karsten Blees (3):
>   MSVC: fix compile errors due to missing libintl.h
>   MSVC: fix compile errors due to macro redefinitions
>   MSVC: fix stat definition hell
>
>  compat/mingw.h   | 21 +
>  compat/msvc.h| 15 ---
>  config.mak.uname |  1 +
>  3 files changed, 18 insertions(+), 19 deletions(-)

I won't be a good person to review, suggest improvements on, and/or
judge these patches.  I'm Cc'ing regulars who work on mingw port for
their help and Ack.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html