Re: [PATCH 0/4] contrib/subtree: general updates

2013-03-23 Thread Paul Campbell
On Thu, Mar 14, 2013 at 3:30 AM, Junio C Hamano gits...@pobox.com wrote:
 Miles Bader mi...@gnu.org writes:

 Paul Campbell pcampb...@kemitix.net writes:
 James and Michael's patches add if clauses that use the
 bashism 'if []' rather than 'if test'.

 Bashism...?  I dunno how portable is, but [ is an old unix alias
 for test ... it certainly predates bash...

 Correct. [[ ... ]] is new and spelling out test indeed is more
 traditionalist than [ ... ], but for contrib/subtree/ that does not
 work with anything but bash, I do not think such a rewrite has much
 merit in the first place.  Being consistently bash script (as
 opposed to being old-style) is more appropriate for it.



Does no-one have any other comments about these patches?

-- 
Paul [W] Campbell
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] contrib/subtree: general updates

2013-03-13 Thread Miles Bader
Paul Campbell pcampb...@kemitix.net writes:
 James and Michael's patches add if clauses that use the
 bashism 'if []' rather than 'if test'.

Bashism...?  I dunno how portable is, but [ is an old unix alias
for test ... it certainly predates bash...

-miles

-- 
Occam's razor split hairs so well, I bought the whole argument!
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html