Re: [PATCH 0/6] Rename files to use dashes instead of underscores
On Tue, Apr 10, 2018 at 02:26:15PM -0700, Stefan Beller wrote: > This is the followup for > https://public-inbox.org/git/xmqqbmer4vfh@gitster-ct.c.googlers.com/ > > We have no files left with underscores in their names. This series looked good to me. It's a nice change. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 signature.asc Description: PGP signature
Re: [PATCH 0/6] Rename files to use dashes instead of underscores
Hi Johannes,
On Tue, Apr 10, 2018 at 3:39 PM, Johannes Schindelin
wrote:
> Hi Stefan,
>
> On Tue, 10 Apr 2018, Stefan Beller wrote:
>
>> This is the followup for
>> https://public-inbox.org/git/xmqqbmer4vfh@gitster-ct.c.googlers.com/
>>
>> We have no files left with underscores in their names.
>
> Yaaay!
>
>> Stefan Beller (6):
>> write_or_die.c: rename to use dashes in file name
>> unicode_width.h: rename to use dash in file name
>> exec_cmd: rename to use dash in file name
>> sha1_name.c: rename to use dash in file name
>> sha1_file.c: rename to use dash in file name
>> replace_object.c: rename to use dash in file name
>
> These are all obviously correct (I did not apply the series and used `git
> grep` to verify that nothing underscored is left there, but I trust you to
> have done that already).
Yes and I did not tell the full story.
There is still 'check_bindir' as compile output, such that I ignored it.
And there was sha1dc_git.{h, c} which I also ignored as it is unclear
to me how our relationship with the DC library is.
I think that could also be converted as it seems to be a shallow wrapper
around that lib.
Re: [PATCH 0/6] Rename files to use dashes instead of underscores
Hi Stefan, On Tue, 10 Apr 2018, Stefan Beller wrote: > This is the followup for > https://public-inbox.org/git/xmqqbmer4vfh@gitster-ct.c.googlers.com/ > > We have no files left with underscores in their names. Yaaay! > Stefan Beller (6): > write_or_die.c: rename to use dashes in file name > unicode_width.h: rename to use dash in file name > exec_cmd: rename to use dash in file name > sha1_name.c: rename to use dash in file name > sha1_file.c: rename to use dash in file name > replace_object.c: rename to use dash in file name These are all obviously correct (I did not apply the series and used `git grep` to verify that nothing underscored is left there, but I trust you to have done that already). Ciao, Dscho
Re: [PATCH 0/6] Rename files to use dashes instead of underscores
On Tue, Apr 10, 2018 at 2:26 PM, Stefan Beller wrote: > This is the followup for > https://public-inbox.org/git/xmqqbmer4vfh@gitster-ct.c.googlers.com/ > > We have no files left with underscores in their names. > It applies on master, and also contains that patch for replace_objects, which I would intend to drop from that other series.
