Re: [PATCH 00/14] Remove unused code from imap-send.c
On 01/14/2013 07:57 AM, Jonathan Nieder wrote: Michael Haggerty wrote: imap-send.c | 286 +--- 1 file changed, 39 insertions(+), 247 deletions(-) See my replies for comments on patches 1, 6, 9, 11, and 12. The rest are Reviewed-by: Jonathan Nieder jrnie...@gmail.com The series is tasteful and easy to follow and it's hard to argue with the resulting code reduction. Thanks for a pleasant read. Thanks for your careful review. I will re-roll the patch series as soon as I get the chance. Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/14] Remove unused code from imap-send.c
Michael Haggerty mhag...@alum.mit.edu writes: On 01/14/2013 07:57 AM, Jonathan Nieder wrote: Michael Haggerty wrote: imap-send.c | 286 +--- 1 file changed, 39 insertions(+), 247 deletions(-) See my replies for comments on patches 1, 6, 9, 11, and 12. The rest are Reviewed-by: Jonathan Nieder jrnie...@gmail.com The series is tasteful and easy to follow and it's hard to argue with the resulting code reduction. Thanks for a pleasant read. Thanks for your careful review. I will re-roll the patch series as soon as I get the chance. Thanks, all of you. The numbers and the graph look very nice indeed ;-) -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/14] Remove unused code from imap-send.c
On Mon, Jan 14, 2013 at 06:32:32AM +0100, Michael Haggerty wrote: As discussed before [1], imap-send.c was copied from isync, including a lot of code that is not used within the git project. This patch series rips a bunch of it out. Thanks, this looks like a good direction. I did not notice any problems reading through the patches, but my brain is frazzled from a day of flying. I missed the problem Jonathan noticed. :) Some of the things you are removing are for advanced IMAP features that imap-send does not need. In theory, somebody might extend it to use them in the future. But since it has not seen any active feature development in years, and since anybody could resurrect the code by reverting your commits, I don't think it is a big risk. I suspect you could go even further in ripping things out (e.g., I do not think a server will generate an untagged namespace response at all if we do not ask for it by issuing a namespace command). But you've certainly grabbed the low-hanging fruit that can mostly be verified by the compiler, and I don't know if it's worth the effort to go much further, as it would require a lot of manual verification (and understanding of IMAP, which will rot your brain). -Peff -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/14] Remove unused code from imap-send.c
Michael Haggerty wrote: imap-send.c | 286 +--- 1 file changed, 39 insertions(+), 247 deletions(-) See my replies for comments on patches 1, 6, 9, 11, and 12. The rest are Reviewed-by: Jonathan Nieder jrnie...@gmail.com The series is tasteful and easy to follow and it's hard to argue with the resulting code reduction. Thanks for a pleasant read. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
