Re: [PATCH 00/26] Clean up update-refs --stdin and implement ref_transaction

2014-03-10 Thread Michael Haggerty
On 03/10/2014 06:44 PM, Brad King wrote: > [...] Thanks for your kind words. > On 03/10/2014 08:46 AM, Michael Haggerty wrote: >> The new API for dealing with reference transactions is >> >> ref_transaction *transaction = create_ref_transaction(); >> queue_create_ref(transaction, refname,

Re: [PATCH 00/26] Clean up update-refs --stdin and implement ref_transaction

2014-03-10 Thread Brad King
Hi Michael, This is excellent work. I haven't reviewed every line of logic in detail but the changes look correct at a high level. The only exception is that the empty is supposed to be accepted and treated as zero even in "--stdin -z" mode. See my response to that individual change. On 03/10