Ronnie Sahlberg <sahlb...@google.com> writes:

> Signed-off-by: Ronnie Sahlberg <sahlb...@google.com>
> ---
>  wrapper.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/wrapper.c b/wrapper.c
> index bc1bfb8..740e193 100644
> --- a/wrapper.c
> +++ b/wrapper.c
> @@ -429,14 +429,12 @@ int xmkstemp_mode(char *template, int mode)
>  
>  static int warn_if_unremovable(const char *op, const char *file, int rc)
>  {
> -     if (rc < 0) {
> -             int err = errno;
> -             if (ENOENT != err) {
> -                     warning("unable to %s %s: %s",
> -                             op, file, strerror(errno));
> -                     errno = err;
> -             }
> -     }
> +     int err;
> +     if (rc >= 0 || errno == ENOENT)
> +             return rc;
> +     err = errno;
> +     warning("unable to %s %s: %s", op, file, strerror(errno));
> +     errno = err;
>       return rc;
>  }

Looks sensible.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to