Re: [PATCH 05/16] replace-object: eliminate replace objects prepared flag

2018-04-10 Thread René Scharfe
Am 10.04.2018 um 00:45 schrieb Stefan Beller: > By making the oidmap a pointer, we eliminate the need for > the global boolean variable 'replace_object_prepared'. > > Signed-off-by: Stefan Beller > --- > object-store.h | 2 +- > replace-object.c | 16 +--- >

Re: [PATCH 05/16] replace-object: eliminate replace objects prepared flag

2018-04-09 Thread Junio C Hamano
Stefan Beller writes: > By making the oidmap a pointer, we eliminate the need for > the global boolean variable 'replace_object_prepared'. That is not quite a justification for this change, as making it a pointer (and paying for the malloc(3) overhead) is not the only way to