Re: [PATCH 06/15] sequencer: lib'ify read_populate_todo()

2016-08-26 Thread Junio C Hamano
Johannes Schindelin writes: > In short: I would really appreciate it if you could cut quoted text after > your last response. I think you are referring to the patch part in this case. As I was not making point-by-point comments on the proposed commit log message,

Re: [PATCH 06/15] sequencer: lib'ify read_populate_todo()

2016-08-26 Thread Johannes Schindelin
Hi Junio, On Thu, 25 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > To be truly useful, the sequencer should never die() but always return > > an error. > > > > Signed-off-by: Johannes Schindelin > > --- > >

Re: [PATCH 06/15] sequencer: lib'ify read_populate_todo()

2016-08-25 Thread Junio C Hamano
Johannes Schindelin writes: > To be truly useful, the sequencer should never die() but always return > an error. > > Signed-off-by: Johannes Schindelin > --- > sequencer.c | 14 +- > 1 file changed, 9 insertions(+), 5

Re: [PATCH 06/15] sequencer: lib'ify read_populate_todo()

2016-08-24 Thread Johannes Schindelin
Hi Eric, On Wed, 24 Aug 2016, Eric Sunshine wrote: > On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin > wrote: > > To be truly useful, the sequencer should never die() but always return > > an error. > > > > Signed-off-by: Johannes Schindelin

Re: [PATCH 06/15] sequencer: lib'ify read_populate_todo()

2016-08-24 Thread Eric Sunshine
On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin wrote: > To be truly useful, the sequencer should never die() but always return > an error. > > Signed-off-by: Johannes Schindelin > --- > diff --git a/sequencer.c b/sequencer.c > @@