Re: [PATCH 09/17] gc_boundary(): move the check alloc = nr to caller

2013-05-23 Thread Michael Haggerty
On 05/21/2013 07:49 PM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: There is no logical reason for this test to be here. At the caller we might be able to figure out its meaning. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- I do not think this change

Re: [PATCH 09/17] gc_boundary(): move the check alloc = nr to caller

2013-05-23 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: 1. The function name gc_boundary() suggests that it will do a garbage collection unconditionally. In fact, it might or might not depending on this test. At the caller, this made it look like a gc was happening each time through the loop, which

Re: [PATCH 09/17] gc_boundary(): move the check alloc = nr to caller

2013-05-21 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: There is no logical reason for this test to be here. At the caller we might be able to figure out its meaning. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- I do not think this change is justified, *unless* the caller later in the