Re: [PATCH 1/1] Add pthread support in QNX. Do not declare NO_ macros if they can be autodetected.

2013-02-26 Thread Junio C Hamano
Mike Gorchak mike.gorchak@gmail.com writes: Also, please leave the autodetection out. If it is common to have strcasestr (or any other) on a newer QNX, then not defining the symbol NO_STRCASESTR in this file may still be the right thing to do, but the justification for such a change

Re: [PATCH 1/1] Add pthread support in QNX. Do not declare NO_ macros if they can be autodetected.

2013-02-26 Thread Mike Gorchak
I saw Matt has comment on this patch, so I'll keep the patch out of 'next' for now and let you two figure it out. Anyway in current form this patch is broken. Junio, may I ask you about the rest patches in a separate posts, have you applied any of them? Thanks. -- To unsubscribe from this

Re: [PATCH 1/1] Add pthread support in QNX. Do not declare NO_ macros if they can be autodetected.

2013-02-25 Thread Junio C Hamano
Mike Gorchak mike.gorchak@gmail.com writes: Add pthread support in QNX. Do not declare NO_ macros if they can be autodetected. From: Mike Gorchak mike.gorchak@gmail.com Signed-off-by: Mike Gorchak mike.gorchak@gmail.com One procedural nit. Please drop that From: immediately

Re: [PATCH 1/1] Add pthread support in QNX. Do not declare NO_ macros if they can be autodetected.

2013-02-25 Thread Mike Gorchak
Also, please leave the autodetection out. If it is common to have strcasestr (or any other) on a newer QNX, then not defining the symbol NO_STRCASESTR in this file may still be the right thing to do, but the justification for such a change should not be because we rely on autodetection. The