Eric Sunshine sunsh...@sunshineco.com writes:
A patch of this nature doesn't require much more description than
stating what it does (replace memcmp() with starts_with()) and why
(improve code clarity). The following rewrite might be sufficient:
Subject: replace memcmp() with
Quint Guvernator quintus.pub...@gmail.com writes:
memcmp() is replaced with negated starts_with() when comparing strings
from the beginning and when it is logical to do so. starts_with() looks
nicer and it saves the extra argument of the length of the comparing
string.
Signed-off-by: Quint
On Mon, Mar 17, 2014 at 03:52:51PM -0700, Junio C Hamano wrote:
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 3e1d5c3..4135980 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -193,7 +193,7 @@ static int verify_format(const char *format)
Jeff King p...@peff.net writes:
On Mon, Mar 17, 2014 at 03:52:51PM -0700, Junio C Hamano wrote:
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 3e1d5c3..4135980 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -193,7 +193,7 @@ static int
2014-03-17 18:52 GMT-04:00 Junio C Hamano gits...@pobox.com:
Thanks. This probably needs retitled, though (hint: replaces?
who does so?) and the message rewritten (see numerous reviews on
other GSoC micros from Eric).
I found some messages [1] by Eric concerning imperative voice (simplify
On Mon, Mar 17, 2014 at 7:46 PM, Quint Guvernator
quintus.pub...@gmail.com wrote:
2014-03-17 18:52 GMT-04:00 Junio C Hamano gits...@pobox.com:
Thanks. This probably needs retitled, though (hint: replaces?
who does so?) and the message rewritten (see numerous reviews on
other GSoC micros from
2014-03-17 21:59 GMT-04:00 Eric Sunshine sunsh...@sunshineco.com:
I can't speak for Junio, but the description could be made more
concise and to-the-point. Aside from using imperative voice, you can
eliminate redundancy, some of which comes from repeating in prose what
the patch itself already
On Mon, Mar 17, 2014 at 04:07:00PM -0700, Junio C Hamano wrote:
-if (!memcmp(used_atom[at], color:, 6))
+if (starts_with(used_atom[at], color:))
need_color_reset_at_eol =
!!strcmp(used_atom[at], color_reset);
[...]
What if
On Mon, Mar 17, 2014 at 10:33 PM, Quint Guvernator
quintus.pub...@gmail.com wrote:
2014-03-17 21:59 GMT-04:00 Eric Sunshine sunsh...@sunshineco.com:
I can't speak for Junio, but the description could be made more
concise and to-the-point. Aside from using imperative voice, you can
eliminate
9 matches
Mail list logo