Re: [PATCH 1/2] repack: rewrite the shell script in C

2013-09-17 Thread Stefan Beller
On 09/15/2013 05:31 PM, Stefan Beller wrote: > Rene, thank you very much for the review! > > the parameter hex contains the "pack-" already. > The remove_redundant_pack function is called in a loop iterating over > elements of existing_packs, which is filled in get_non_kept_pack_filenames, > whic

Re: [PATCH 1/2] repack: rewrite the shell script in C

2013-09-15 Thread Stefan Beller
Rene, thank you very much for the review! On 09/15/2013 01:42 PM, René Scharfe wrote: >> +static void remove_temporary_files(void) >> +{ >> +struct strbuf buf = STRBUF_INIT; >> +size_t dirlen, prefixlen; >> +DIR *dir; >> +struct dirent *e; >> + >> +dir = opendir(packdir); >> +

Re: [PATCH 1/2] repack: rewrite the shell script in C

2013-09-15 Thread René Scharfe
Am 29.08.2013 22:39, schrieb Stefan Beller: The motivation of this patch is to get closer to a goal of being able to have a core subset of git functionality built in to git. That would mean * people on Windows could get a copy of at least the core parts of Git without having to install a Uni

Re: [PATCH 1/2] repack: rewrite the shell script in C

2013-08-29 Thread Felipe Contreras
On Thu, Aug 29, 2013 at 3:39 PM, Stefan Beller wrote: > The motivation of this patch is to get closer to a goal of being > able to have a core subset of git functionality built in to git. > That would mean > > * people on Windows could get a copy of at least the core parts >of Git without hav