Re: [PATCH 1/3] gitweb: Fix an ancient typo in v1.7.7-rc1-1-g0866786
On Wed, Sep 21, 2016 at 7:14 PM, Jakub Narębski wrote: > W dniu 21.09.2016 o 16:17, Ævar Arnfjörð Bjarmason napisał: >> On Wed, Sep 21, 2016 at 3:33 PM, Jakub Narębski wrote: >>> W dniu 21.09.2016 o 13:44, Ævar Arnfjörð Bjarmason napisał: > [...] > -# Sanitize for use in XHTML + application/xml+xhtm (valid XML 1.0) +# Sanitize for use in XHTML + application/xml+xhtml (valid XML 1.0) >>> >>> Nb. I wonder how common is use of XHTML nowadays, with HTML5 as standard... >> >> It's sent to modern browsers, I noticed it because when doing the rest >> of the patches in the series the slightest mistake in the HTML syntax >> would cause the page not to render in Chrome, because >> application/xml+xhtml activates its anal parsing mode. > > What I wanted to say is if we should support XHTML mimetype at all; > the future is HTML5 and perhaps gitweb should always use 'text/html'. Regardless of what MIME type we'd normally use, as long as browsers support application/xml+xhtml developing with it is very handy, because you get the instant equivalent of compile errors for your HTML, as opposed to the usual behavior of "oh this doesn't parse, but let's try to make sense of it anyway", which often leads to fruitless debugging sessions just because you forgot to close some tag or quotation.
Re: [PATCH 1/3] gitweb: Fix an ancient typo in v1.7.7-rc1-1-g0866786
W dniu 21.09.2016 o 16:17, Ævar Arnfjörð Bjarmason napisał: > On Wed, Sep 21, 2016 at 3:33 PM, Jakub Narębski wrote: >> W dniu 21.09.2016 o 13:44, Ævar Arnfjörð Bjarmason napisał: [...] >>> -# Sanitize for use in XHTML + application/xml+xhtm (valid XML 1.0) >>> +# Sanitize for use in XHTML + application/xml+xhtml (valid XML 1.0) >> >> Nb. I wonder how common is use of XHTML nowadays, with HTML5 as standard... > > It's sent to modern browsers, I noticed it because when doing the rest > of the patches in the series the slightest mistake in the HTML syntax > would cause the page not to render in Chrome, because > application/xml+xhtml activates its anal parsing mode. What I wanted to say is if we should support XHTML mimetype at all; the future is HTML5 and perhaps gitweb should always use 'text/html'. But this is unrelated to this change... -- Jakub Narębski
Re: [PATCH 1/3] gitweb: Fix an ancient typo in v1.7.7-rc1-1-g0866786
On Wed, Sep 21, 2016 at 3:33 PM, Jakub Narębski wrote:
> W dniu 21.09.2016 o 13:44, Ævar Arnfjörð Bjarmason napisał:
>
>> Subject: [PATCH 1/3] gitweb: Fix an ancient typo in v1.7.7-rc1-1-g0866786
>
> It is more "ancient typo from v1.7.7-rc1-1-g0866786", but perhaps more
> important is "ancient typo in a comment"
Yeah, will rephrase.
>>
>> The Content-Type is application/xhtml+xml, not application/xhtm+xml.
>
> Right. Thanks for the patch.
>
> Signoff?
Blast! I forgot that for these 3x patches. I'll re-submit pending
further comments on the rest of the code changes in the series.
>> ---
>> gitweb/gitweb.perl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index 33d701d..9473daf 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -1616,7 +1616,7 @@ sub esc_path {
>> return $str;
>> }
>>
>> -# Sanitize for use in XHTML + application/xml+xhtm (valid XML 1.0)
>> +# Sanitize for use in XHTML + application/xml+xhtml (valid XML 1.0)
>
> Nb. I wonder how common is use of XHTML nowadays, with HTML5 as standard...
It's sent to modern browsers, I noticed it because when doing the rest
of the patches in the series the slightest mistake in the HTML syntax
would cause the page not to render in Chrome, because
application/xml+xhtm activates its anal parsing mode.
>> sub sanitize {
>> my $str = shift;
>>
>>
>
Re: [PATCH 1/3] gitweb: Fix an ancient typo in v1.7.7-rc1-1-g0866786
W dniu 21.09.2016 o 13:44, Ævar Arnfjörð Bjarmason napisał:
> Subject: [PATCH 1/3] gitweb: Fix an ancient typo in v1.7.7-rc1-1-g0866786
It is more "ancient typo from v1.7.7-rc1-1-g0866786", but perhaps more
important is "ancient typo in a comment"
>
> The Content-Type is application/xhtml+xml, not application/xhtm+xml.
Right. Thanks for the patch.
Signoff?
> ---
> gitweb/gitweb.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 33d701d..9473daf 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1616,7 +1616,7 @@ sub esc_path {
> return $str;
> }
>
> -# Sanitize for use in XHTML + application/xml+xhtm (valid XML 1.0)
> +# Sanitize for use in XHTML + application/xml+xhtml (valid XML 1.0)
Nb. I wonder how common is use of XHTML nowadays, with HTML5 as standard...
> sub sanitize {
> my $str = shift;
>
>
