Re: [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

2013-05-10 Thread Junio C Hamano
Eric Sunshine writes: > On Fri, May 10, 2013 at 10:29 AM, Ramkumar Ramachandra > wrote: >> test-lib.sh already sets a sane GIT_AUTHOR_{NAME,EMAIL} for all test >> scripts to use. Don't unnecessarily duplicate the work. >> >> Signed-off-by: Ramkumar Ramachandra >> --- >> t/t3400-rebase.sh | 4

Re: [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

2013-05-10 Thread Ramkumar Ramachandra
Eric Sunshine wrote: > These values are intentionally bogus. Doesn't this change defeat the > purpose of 43c2325 (am: use get_author_ident_from_commit instead of > mailinfo when rebasing; 2010-06-16)? Oh, oops. I paid too little attention to this series. Thanks for catching. -- To unsubscribe fr

Re: [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

2013-05-10 Thread Eric Sunshine
On Fri, May 10, 2013 at 10:29 AM, Ramkumar Ramachandra wrote: > test-lib.sh already sets a sane GIT_AUTHOR_{NAME,EMAIL} for all test > scripts to use. Don't unnecessarily duplicate the work. > > Signed-off-by: Ramkumar Ramachandra > --- > t/t3400-rebase.sh | 4 > 1 file changed, 4 deletion