Re: [PATCH 1/6] t/send-email.sh: add test for suppress self

2013-05-29 Thread Michael S. Tsirkin
On Wed, May 29, 2013 at 03:59:51PM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > >> If we don't want to use \, this can also be done like this: > >> > >> FOO << EOF && > >> BLABLA > >> EOF > >> BAR && > >> VAR > >> > >> I think this is what you suggest. > > > > Yup, that is exactl

Re: [PATCH 1/6] t/send-email.sh: add test for suppress self

2013-05-29 Thread Junio C Hamano
Junio C Hamano writes: >> If we don't want to use \, this can also be done like this: >> >> FOO << EOF && >> BLABLA >> EOF >> BAR && >> VAR >> >> I think this is what you suggest. > > Yup, that is exactly what I meant (but no leading indentation before > BAR and VAR). > > That way, it is a lo

Re: [PATCH 1/6] t/send-email.sh: add test for suppress self

2013-05-29 Thread Junio C Hamano
"Michael S. Tsirkin" writes: >> > +test_suppress_self () { >> > + test_commit $3 && >> > + test_when_finished "git reset --hard HEAD^" && >> > + { >> > + echo "#!$SHELL_PATH" >> > + echo sed -n -e s/^cccmd--//p \"\$1\" >> > + }

Re: [PATCH 1/6] t/send-email.sh: add test for suppress self

2013-05-29 Thread Michael S. Tsirkin
On Wed, May 29, 2013 at 01:28:52PM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > Signed-off-by: Michael S. Tsirkin > > --- > > Thanks. Thanks, I'll address your comments and repost. You asked some questions below, so I tried to answer. > > t/t9001-send-email.sh | 41 +

Re: [PATCH 1/6] t/send-email.sh: add test for suppress self

2013-05-29 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > Signed-off-by: Michael S. Tsirkin > --- Thanks. > t/t9001-send-email.sh | 41 + > 1 file changed, 41 insertions(+) > > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh > index ebd5c5d..36ecf73 100755 > --- a/t/t9