Re: [PATCH 1/7] am: suppress error output from a conditional
On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra artag...@gmail.com wrote: When testing if the $dotest directory exists, and if $next is greater than $last When can that happen? If one edits the todo? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/7] am: suppress error output from a conditional
Martin von Zweigbergk martinv...@gmail.com writes: On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra artag...@gmail.com wrote: When testing if the $dotest directory exists, and if $next is greater than $last When can that happen? If one edits the todo? More importantly, that condition is an unexpected error, which the user may need to supply to help diagnosing the issue better, isn't it? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/7] am: suppress error output from a conditional
Martin von Zweigbergk wrote: On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra artag...@gmail.com wrote: When testing if the $dotest directory exists, and if $next is greater than $last When can that happen? If one edits the todo? When git-rebase.sh creates a $dotest directory with just an autostash file :) Like I said in my cover letter, I really wrote [7/7] first, and kept modifying things until all the tests passed. So, I can't really justify these changes independent of [7/7]. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/7] am: suppress error output from a conditional
Ramkumar Ramachandra artag...@gmail.com writes: Martin von Zweigbergk wrote: On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra artag...@gmail.com wrote: When testing if the $dotest directory exists, and if $next is greater than $last When can that happen? If one edits the todo? When git-rebase.sh creates a $dotest directory with just an autostash file :) Like I said in my cover letter, I really wrote [7/7] first, and kept modifying things until all the tests passed. So, I can't really justify these changes independent of [7/7]. That explains a lot of mystery ;-) Perhaps all of these oops, 7/7 breaks this and that so let's work them around can be avoided if the series did not store the object name of the stash that records the local changes as a plain text file inside a $dotest/ directory, and instead used a dedicated ref somewhere under refs/ hierarchy, no? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/7] am: suppress error output from a conditional
Junio C Hamano wrote: Perhaps all of these oops, 7/7 breaks this and that so let's work them around can be avoided if the series did not store the object name of the stash that records the local changes as a plain text file inside a $dotest/ directory, and instead used a dedicated ref somewhere under refs/ hierarchy, no? Exactly. Which is why I was asking for named stashes on the other thread. Much cleaner than keeping track of it yourself. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
