Re: [PATCH 1/8] xdl_change_compact(): rename some local variables for clarity

2016-08-14 Thread Jeff King
On Sat, Aug 13, 2016 at 09:38:33PM +0200, Michael Haggerty wrote: > On 08/04/2016 09:06 AM, Jeff King wrote: > > On Thu, Aug 04, 2016 at 12:00:29AM +0200, Michael Haggerty wrote: > > > >> * ix -> i > >> * ixo -> io > >> * ixs -> start > >> * grpsiz -> groupsize > > > > After your change, I immed

Re: [PATCH 1/8] xdl_change_compact(): rename some local variables for clarity

2016-08-14 Thread Michael Haggerty
On 08/04/2016 09:06 AM, Jeff King wrote: > On Thu, Aug 04, 2016 at 12:00:29AM +0200, Michael Haggerty wrote: > >> * ix -> i >> * ixo -> io >> * ixs -> start >> * grpsiz -> groupsize > > After your change, I immediately understand three of them. But what is > "io"? The (pre-existing) convention i

Re: [PATCH 1/8] xdl_change_compact(): rename some local variables for clarity

2016-08-04 Thread Junio C Hamano
Jeff King writes: > On Thu, Aug 04, 2016 at 12:00:29AM +0200, Michael Haggerty wrote: > >> * ix -> i >> * ixo -> io >> * ixs -> start >> * grpsiz -> groupsize > > After your change, I immediately understand three of them. But what is > "io"? I had the same reaction. -- To unsubscribe from this

Re: [PATCH 1/8] xdl_change_compact(): rename some local variables for clarity

2016-08-04 Thread Jeff King
On Thu, Aug 04, 2016 at 12:00:29AM +0200, Michael Haggerty wrote: > * ix -> i > * ixo -> io > * ixs -> start > * grpsiz -> groupsize After your change, I immediately understand three of them. But what is "io"? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of