Re: [PATCH 14/33] refs: extract a function peel_entry()

2013-04-16 Thread Michael Haggerty
On 04/16/2013 07:55 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> On 04/15/2013 07:38 PM, Junio C Hamano wrote: >>> Michael Haggerty writes: >>> if (read_ref_full(refname, base, 1, &flag)) return -1; - if ((flag & REF_ISPACKED)) { + /*

Re: [PATCH 14/33] refs: extract a function peel_entry()

2013-04-16 Thread Junio C Hamano
Michael Haggerty writes: > On 04/15/2013 07:38 PM, Junio C Hamano wrote: >> Michael Haggerty writes: >> >>> if (read_ref_full(refname, base, 1, &flag)) >>> return -1; >>> >>> - if ((flag & REF_ISPACKED)) { >>> + /* >>> +* If the reference is packed, read its ref_entry

Re: [PATCH 14/33] refs: extract a function peel_entry()

2013-04-16 Thread Michael Haggerty
On 04/15/2013 07:38 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> if (read_ref_full(refname, base, 1, &flag)) >> return -1; >> >> -if ((flag & REF_ISPACKED)) { >> +/* >> + * If the reference is packed, read its ref_entry from the >> + * cache in the

Re: [PATCH 14/33] refs: extract a function peel_entry()

2013-04-15 Thread Junio C Hamano
Michael Haggerty writes: > if (read_ref_full(refname, base, 1, &flag)) > return -1; > > - if ((flag & REF_ISPACKED)) { > + /* > + * If the reference is packed, read its ref_entry from the > + * cache in the hope that we already know its peeled value. > +