Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-06-14 Thread Junio C Hamano
René Scharfe writes: > > This adds a minor memory leak; fix below. > > -- >8 -- > Subject: [PATCH] blame: release string_list after use in parse_color_fields() > > Signed-off-by: Rene Scharfe > --- Thanks. Will apply. > builtin/blame.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-06-11 Thread Stefan Beller
On Sat, Jun 9, 2018 at 4:26 AM René Scharfe wrote: > > Am 17.04.2018 um 23:30 schrieb Stefan Beller: > > +static void parse_color_fields(const char *s) > > +{ > > + struct string_list l = STRING_LIST_INIT_DUP; > > + struct string_list_item *item; > > + enum { EXPECT_DATE, EXPECT_COLOR

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-06-09 Thread René Scharfe
Am 17.04.2018 um 23:30 schrieb Stefan Beller: > +static void parse_color_fields(const char *s) > +{ > + struct string_list l = STRING_LIST_INIT_DUP; > + struct string_list_item *item; > + enum { EXPECT_DATE, EXPECT_COLOR } next = EXPECT_COLOR; > + > + colorfield_nr = 0; > + > +

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-04-17 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, Apr 17, 2018 at 5:30 PM, Stefan Beller wrote: >> Choose a different color for dates and imitate a 'temperature cool down' >> depending upon age. >> >> Originally I had planned to have the temperature cooldown dependent on >> the age of the project or file for exam

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-04-17 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Apr 16, 2018 at 8:29 PM, Junio C Hamano wrote: >> It seems that this >> >> $ git -c color.blame.repeatedlines=cyan blame --heated-lines builtin/blame.c >> >> refuses to run. >> >> Would it work if the configuration is in .git/config instead, or >> would it forever

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-04-17 Thread Eric Sunshine
On Tue, Apr 17, 2018 at 5:30 PM, Stefan Beller wrote: > Choose a different color for dates and imitate a 'temperature cool down' > depending upon age. > > Originally I had planned to have the temperature cooldown dependent on > the age of the project or file for example, as that might scale better

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-04-17 Thread Stefan Beller
On Tue, Apr 17, 2018 at 12:31 PM, Stefan Beller wrote: > On Mon, Apr 16, 2018 at 8:29 PM, Junio C Hamano wrote: >> It seems that this >> >> $ git -c color.blame.repeatedlines=cyan blame --heated-lines builtin/blame.c >> >> refuses to run. >> >> Would it work if the configuration is in .git/config

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-04-17 Thread Stefan Beller
On Mon, Apr 16, 2018 at 8:29 PM, Junio C Hamano wrote: > It seems that this > > $ git -c color.blame.repeatedlines=cyan blame --heated-lines builtin/blame.c > > refuses to run. > > Would it work if the configuration is in .git/config instead, or > would it forever disable --heated-lines once someb

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-04-16 Thread Junio C Hamano
It seems that this $ git -c color.blame.repeatedlines=cyan blame --heated-lines builtin/blame.c refuses to run. Would it work if the configuration is in .git/config instead, or would it forever disable --heated-lines once somebody choses to use --color-lines feature by default by configuring it

Re: [PATCH 2/2] builtin/blame: highlight recently changed lines

2018-04-16 Thread Junio C Hamano
Stefan Beller writes: > Choose a different color for dates and imitate a 'temperature cool down' > depending upon age. > > Originally I had planned to have the temperature cooldown dependent on > the age of the project or file for example, as that might scale better, > but that can be added on to