Re: [PATCH 2/2] commit-slab: declare functions "static inline"

2013-12-01 Thread Duy Nguyen
Thomas, As you're touching this, perhaps you coud fix this line in slabname_at() too? s->slab = xrealloc(s->slab, (nth_slab + 1) * sizeof(s->slab)); I think it should be sizeof(*s->slab), not sizeof(s->slab), even though the end result is the same. -- Duy -- To unsubscribe from this list: send

Re: [PATCH 2/2] commit-slab: declare functions "static inline"

2013-11-25 Thread Thomas Rast
Junio C Hamano writes: > Thomas Rast writes: > >> This shuts up compiler warnings about unused functions. > > Thanks. > >> While there, also remove the redundant second declaration of >> stat_##slabname##realloc. > > I think the latter was done very much deliberately to allow the > using code to

Re: [PATCH 2/2] commit-slab: declare functions "static inline"

2013-11-25 Thread Junio C Hamano
Thomas Rast writes: > This shuts up compiler warnings about unused functions. Thanks. > While there, also remove the redundant second declaration of > stat_##slabname##realloc. I think the latter was done very much deliberately to allow the using code to say: define_commit_slab(name,