Re: [PATCH 2/2] difftool: don't assume that default sh is sane

2014-07-29 Thread David Aguilar
On Sat, Jul 19, 2014 at 05:35:17PM +0100, Charles Bailey wrote: From: Charles Bailey cbaile...@bloomberg.net git-difftool used to create a command list script containing $( ... ) and explicitly call sh -c with this list. Instead, allow mergetool --tool-help to take a mode parameter and

Re: [PATCH 2/2] difftool: don't assume that default sh is sane

2014-07-19 Thread John Keeping
On Sat, Jul 19, 2014 at 05:35:17PM +0100, Charles Bailey wrote: From: Charles Bailey cbaile...@bloomberg.net git-difftool used to create a command list script containing $( ... ) and explicitly call sh -c with this list. Instead, allow mergetool --tool-help to take a mode parameter and

Re: [PATCH 2/2] difftool: don't assume that default sh is sane

2014-07-19 Thread Charles Bailey
On Sat, Jul 19, 2014 at 06:21:32PM +0100, John Keeping wrote: What's the reason for forcing `--tool-help` to be the last option? Wouldn't it be simpler to just change the top-level case statement to: --tool-help=*) TOOL_MODE=${1#--tool-help=}