Re: [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/'

2013-08-25 Thread Jonathan Nieder
Eric Sunshine wrote: Although undocumented, directory_exists_in_index_icase(dirname,len) unconditionally assumes the presence of a '/' at dirname[len] (despite being past the end-of-string). Callers are expected to respect [...] Fix this problem.

Re: [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/'

2013-08-25 Thread Eric Sunshine
On Sun, Aug 25, 2013 at 2:00 AM, Jonathan Nieder jrnie...@gmail.com wrote: Eric Sunshine wrote: Although undocumented, directory_exists_in_index_icase(dirname,len) unconditionally assumes the presence of a '/' at dirname[len] (despite being past the end-of-string). Callers are expected to

Re: [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/'

2013-08-25 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: ... A follow-up series [2] fixes both directory_exists_in_index() and directory_exists_in_index_icase() to be more liberal in what they accept, relieving the caller of the burden. By the time that series was posted, however, Junio and Peff had