Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

2017-08-09 Thread Jeff King
On Wed, Aug 09, 2017 at 08:02:33PM +0100, Ian Campbell wrote: > > > Should we instead make git-mktag more lenient (possibly with a > > > command-line option to reduce accidental omissions)? > > > > That sounds sensible. Thanks for injecting a dose of sanity. > > Indeed. I'll add a --allow-missin

Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

2017-08-09 Thread Junio C Hamano
Ian Campbell writes: > Indeed. I'll add a --allow-missing-tagger option (suggestions for a > snappier name accepted!) and pass it unconditionally from the filter- > branch script. Thanks. That's much better.

Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

2017-08-09 Thread Ian Campbell
On Wed, 2017-08-09 at 08:50 -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Tue, Aug 08, 2017 at 09:06:20AM +0100, Ian Campbell wrote: > > > >> Such as v2.6.12-rc2..v2.6.13-rc3 in the Linux kernel source tree. > >>  > >> Insert a fake tag header, since newer `git mktag` wont accept the

Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

2017-08-09 Thread Junio C Hamano
Jeff King writes: > On Tue, Aug 08, 2017 at 09:06:20AM +0100, Ian Campbell wrote: > >> Such as v2.6.12-rc2..v2.6.13-rc3 in the Linux kernel source tree. >> >> Insert a fake tag header, since newer `git mktag` wont accept the input >> otherwise: > > Hmm. Now your resulting tag will have this cruf

Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

2017-08-09 Thread Jeff King
On Tue, Aug 08, 2017 at 09:06:20AM +0100, Ian Campbell wrote: > Such as v2.6.12-rc2..v2.6.13-rc3 in the Linux kernel source tree. > > Insert a fake tag header, since newer `git mktag` wont accept the input > otherwise: Hmm. Now your resulting tag will have this crufty "unkn...@example.com" heade

Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

2017-08-09 Thread Ian Campbell
On Tue, 2017-08-08 at 14:00 -0700, Junio C Hamano wrote: > > @@ -540,6 +540,9 @@ if [ "$filter_tag_name" ]; then > > >   new_sha1=$( ( printf 'object %s\ntype commit\ntag %s\n' > > >\ > > >   "$new_sha1" "$new_ref" > > >  

Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger

2017-08-08 Thread Junio C Hamano
Ian Campbell writes: > Such as v2.6.12-rc2..v2.6.13-rc3 in the Linux kernel source tree. > > Insert a fake tag header, since newer `git mktag` wont accept the input > otherwise: > > $ git cat-file tag v2.6.12-rc2 > object 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 > type commit > ta